[codex] Remove 1.9 atomic create params from 1.8 specs#44
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (30)
💤 Files with no reviewable changes (9)
WalkthroughThis pull request systematically removes optional Estimated code review effort🎯 2 (Simple) | ⏱️ ~15 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Greptile SummaryThis PR surgically removes 1.9.x-only atomic creation parameters (
Confidence Score: 5/5This PR is safe to merge — it is a targeted, correct removal of unsupported parameters from versioned specs and examples with no logic changes. All changes are pure deletions of 1.9.x-only fields from 1.8.x specs and examples. JSON validity is confirmed, syntax in all SDK examples is correct after the removals, coverage across platforms is complete, and no 1.9.x specs were inadvertently touched. No P0 or P1 findings. No files require special attention. Important Files Changed
Reviews (1): Last reviewed commit: "Remove 1.9 atomic create params from 1.8..." | Re-trigger Greptile |
Summary
Removes 1.9-only atomic schema creation parameters from the 1.8.x create API surface.
What changed
attributesandindexesfrom 1.8.xdatabases.createCollectionin the server and console Swagger/OpenAPI specs.columnsandindexesfrom 1.8.xtablesDB.createTablein the server and console Swagger/OpenAPI specs.create-collectionandcreate-tableexamples across SDK/platform directories so they no longer pass those params inline.Why
These inline schema/index creation params are a 1.9.x feature and should not appear in 1.8.x specs or examples.
Impact
Validation
git diff --checkrgverification that 1.8.xdatabases/create-collection.mdexamples no longer include inlineattributes/indexesrgverification that 1.8.xtablesdb/create-table.mdexamples no longer include inlinecolumns/indexesenabledSummary by CodeRabbit
Documentation
API Specification
attributesandindexesproperties from collection creation schemas andcolumnsandindexesfrom table creation schemas.