fix: add missing receipt fields to TurboUploadResponse#6
Open
vilenarios wants to merge 1 commit intoalphafrom
Open
fix: add missing receipt fields to TurboUploadResponse#6vilenarios wants to merge 1 commit intoalphafrom
vilenarios wants to merge 1 commit intoalphafrom
Conversation
The upload API returns timestamp, signature, public, version, and deadlineHeight as part of the signed receipt, but these fields were silently discarded during response parsing in both single and chunked upload paths. - Add receipt fields to TurboUploadResponse and TurboUploadStatus - Extract fields in _upload_single() from API response JSON - Extract fields in get_status() from chunked receipt dict - Carry fields through status→response conversion in upload() - Update tests with new fields and assertions Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
@coderabbitai review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
timestamp,signature,public,version, anddeadline_heighttoTurboUploadResponseandTurboUploadStatusdataclasses_upload_single()from API response JSON (previously discarded)get_status()from chunked upload receipt dictTurboUploadStatus→TurboUploadResponseconversion in chunkedupload()Test plan
pytest tests/test_turbo.py tests/test_chunked.py)🤖 Generated with Claude Code