Add a cleanup/exit callback to CheckForUpdates #7
Conversation
| if cleanup != nil { | ||
| if err := cleanup(); err != nil { | ||
| return fmt.Errorf("cleanup failed: %w", err) | ||
| } | ||
| } |
There was a problem hiding this comment.
We need to be clever here. A long cleanup procedure could interfere with the execApp above. If the app is set to have only one instance, the exec above will fail because the app will run the cleanup while the new one starts. I would say that at least the cleanup should be done before the execApp. But I am wondering if the caller should also run its exit code. Run our self os.Exit is risky because it will prevent the caller from running the deferred functions, so maybe something will not be correctly cleaned.
|
Why isn't the CheckForUpdates function simply return nil and let the caller do the restart? |
Xayton
changed the title
Not only that the caller need to restart the new application instance right after the cleanup and right before the shutdown, but the issue there is that it probably needs to do it after some delay. Who is implementing this delay? We maybe spawn a detached process with a built-in sleep for that. |
|
The linked issue contains a new plan in order to improve the update process, that does not require a cleanup or exit callback. |
3 participants
Motivation
In order to let the an application to gracefully shutdown a cleanup callback function can be run before exiting.
closes https://github.com/arduino/private-tooling-team/issues/351