This repository was archived by the owner on Dec 17, 2025. It is now read-only.
fix(hooks): always remove finalizers on create if hook exists#761
Merged
agaudreault merged 1 commit intoargoproj:release-3.0from Sep 5, 2025
Merged
Conversation
Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release-3.0 #761 +/- ##
==============================================
Coverage ? 47.30%
==============================================
Files ? 64
Lines ? 6557
Branches ? 0
==============================================
Hits ? 3102
Misses ? 3198
Partials ? 257 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
agaudreault
changed the title
crenshaw-dev
approved these changes
Sep 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
partial cherry-pick of #754 to mitigate argoproj/argo-cd#23226 on 3.0.
This does not fix the codepaths that do not remove the finalizers, but allows new sync to work correctly to remediate the issue.