chore: upgrade deps#312
Merged
Merged
Conversation
gregberge
requested review from
a team,
Copilot and
jsfez
and removed request for
a team
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Pull request overview
This PR upgrades workspace tooling dependencies (TypeScript/ESLint/Vitest/Storybook) and refreshes the pnpm lockfile, including pinning the workspace catalog @types/node to ^22.19.19.
Changes:
- Bump the workspace catalog
@types/nodeversion to^22.19.19. - Upgrade dev tooling dependencies (e.g.
@vitest/eslint-plugin,typescript-eslint, Storybook packages) and updatepnpm-lock.yamlaccordingly. - Update the repo’s declared
packageManagertopnpm@11.3.0.
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| pnpm-workspace.yaml | Updates catalog pin for @types/node. |
| pnpm-lock.yaml | Regenerates lockfile for upgraded dependencies. |
| packages/storybook/package.json | Bumps Storybook-related devDependencies to ^10.4.1. |
| package.json | Updates root dev tooling versions and pnpm packageManager. |
Comments suppressed due to low confidence (1)
packages/storybook/package.json:69
@argos-ci/storybookuses Node globals/APIs (e.g.process.cwd()in src) but does not declare@types/nodeindevDependencies. This makes TypeScript/Vitest pick up whichever@types/nodeversion happens to be hoisted (and defeats the workspace catalog pin), which can lead to inconsistent type-checking across packages. Add@types/node: "catalog:"to this package’sdevDependenciesand re-generate the lockfile.
"@storybook/test-runner": "^0.24.4",
"@types/react": "^19.2.15",
"@types/react-dom": "^19.2.3",
"@vitest/browser": "^4.1.7",
"@vitest/browser-playwright": "^4.1.7",
"@vitest/coverage-v8": "^4.1.7",
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.