Lay out generated Scratch scripts - #366
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
project.jsonbefore assembling the.sb3archiveSb3, leaving it as a focused JSON generatorWhy
Generated scripts previously retained incidental coordinates instead of receiving a predictable, readable layout. Cleaning the completed JSON requires buffering it before archive creation, which exposed that
Sb3was unnecessarily coupled to the ZIP writer.The build layer now owns archive assembly while
Sb3owns only project JSON generation and asset collection.Impact
Compiled Scratch projects open with consistently ordered, non-overlapping script stacks. Archive contents and asset deduplication remain unchanged.
Validation
cargo +nightly fmt --checkcargo test --lib(12 passed)tests/varssuccessfullyunzip -tproject.jsonwithjq