Refactor Tutorial 1 to include instructions for specreduce#3
Open
keflavich wants to merge 1 commit into
Open
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Author
|
the pre-commit fixes severely broke my attempts to further edit the file. It is not good that they were included in this case. |
keflavich
force-pushed
the
refactor_for_specreduce
branch
from
e88973c to
85b87fe
Compare
keflavich
force-pushed
the
refactor_for_specreduce
branch
from
34b15d8 to
a1d242e
Compare
Author
|
re: my previous comment - it's not great that I can push, have pre-commit change my commit, then be prevented from pushing the next time. pre-commit introduces conflicts that are hard to resolve. the advice to users is probably: you really need pre-commit to run locally. But in this case, I think that deletes your local rendering, which is itself a pain... I'm not sure the solution, just shouting in the wind |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Title says most of it.
I need to rebase this, but this is my first PR and is also my first test of the new build system.
cc @hpparvi