This repository was archived by the owner on Dec 15, 2022. It is now read-only.
Open
Conversation
Contributor
Author
|
/cc @50Wliu since you pointed this out to me 😀 |
Contributor
|
It looks like these get used further down the line, such as here. Maybe an alternate design would be to throw early when adding a command without a target? |
Contributor
Author
|
Yeah, good point. I may go back to my original idea and just |
UziTech
added a commit
to UziTech/notifications
that referenced
this pull request
Sep 25, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the Change
Protects against an
undefinedcommand target in theCommandLogger.Alternate Designs
targetto beundefinedbut figured that this code should be more flexible than thatBenefits
Possible Drawbacks
undefinedtargetApplicable Issues
Fixes #135