Conversation
cjcolvar
approved these changes
Jun 3, 2026
cjcolvar
left a comment
cjcolvar
left a comment
Member
There was a problem hiding this comment.
This seems like a nice workaround for now. I do wonder if finding a different UUID implementation might be needed but we could probably wait until it we're forced.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue: #277
Changes in this PR:
uuidfromv11->v14uuidfor the Jest test environment so that the tests work. This mocks thev4()(this is the only function used fromuuidlibrary in the SME code at the moment) usingcrypto.randomUUID()instead of re-implementing it.Other considerations: I looked into replacing
uuidentirely withcrypto.randomUUID()which would solve this issue, but it could face security context requirements and legacy environment compatibility issues.