Skip to content

Update README zsh completion for bundled installer#10327

Open
adev-code wants to merge 1 commit into
aws:v2from
adev-code:readmefile
Open

Update README zsh completion for bundled installer#10327
adev-code wants to merge 1 commit into
aws:v2from
adev-code:readmefile

Conversation

@adev-code
Copy link
Copy Markdown
Contributor

Fixes #8957. The README's zsh instructions point to
bin/aws_zsh_completer.sh, which ships with Package Manager
installs (e.g. pip) but not with the bundled installer (zip/pkg).
Bundled-installer users hit "No such file or directory".

Change

Scope the existing zsh block to Package Manager installs and add a
parallel block for the bundled installer using bashcompinit +
complete -C aws_completer aws.

Reference

Configuring command completion in the AWS CLI

The README's zsh section points to bin/aws_zsh_completer.sh, which
is shipped via Package Manager installs (e.g. pip) but not by the
bundled installer (zip/pkg). Bundled-installer users following the
README hit "No such file or directory" when sourcing it.

Keep the existing pip instructions and add a parallel block for
bundled installs using the bashcompinit + complete -C approach
documented in the AWS CLI User Guide. Both methods now coexist
without removing the legacy path that pip users still rely on.

Fixes aws#8957
Comment thread README.rst
Comment on lines -90 to +92
For zsh please refer to ``bin/aws_zsh_completer.sh``. Source that file, e.g.
from your ``~/.zshrc``, and make sure you run ``compinit`` before::
For zsh (Package Manager, e.g. pip installs) please refer to
``bin/aws_zsh_completer.sh``. Source that file, e.g. from your
``~/.zshrc``, and make sure you run ``compinit`` before::
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Source builds should still produce an aws_completer exe:

$ pip install -e .
$ ls .venv/bin | rg "aws"

aws
aws_bash_completer
aws_completer
aws_zsh_completer.sh
aws.cmd

We should be good to just recommend the same set of instructions. Can you confirm?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants