-
Notifications
You must be signed in to change notification settings - Fork 1.2k
feat: sam init output json #9176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
madhavdonthula1
wants to merge
10
commits into
aws:develop
Choose a base branch
from
madhavdonthula1:feat/init3-output-json
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
eec3378
feat(init): Add --output json to sam init
madhavdonthula1 392d8cb
fix(init): Correct --output json result document
madhavdonthula1 7fc0480
refactor(init): Consolidate tests and trim comments
madhavdonthula1 96b0c05
fix(init): Address review feedback on --output json
madhavdonthula1 ca7d266
fix(init): Stop --output from being persisted by --save-params
madhavdonthula1 4f19caf
fix(cli): Scope the --save-params output exclusion by option type
madhavdonthula1 33460f7
refactor(init): Trim inline comments
madhavdonthula1 335ac46
Merge branch 'develop' into feat/init3-output-json
reedham-aws 96db3ec
test(init): Merge two JSON integ tests into one
madhavdonthula1 ddcdbbf
test(init): Share a do_cli helper across the JSON tests
madhavdonthula1 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
14 changes: 14 additions & 0 deletions
14
samcli/commands/_utils/custom_options/structured_output_option.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| """ | ||
| Custom click option for the shared structured output flag | ||
| """ | ||
|
|
||
| import click | ||
|
|
||
|
|
||
| class StructuredOutputOption(click.Option): | ||
| """Marks the shared --output option that selects structured (JSON) output. | ||
|
|
||
| Exists so the option can be recognised by type rather than by name. Other commands, such as | ||
| sam list and sam remote invoke, have an unrelated --output that selects a display format and | ||
| is worth saving to a config file, while this one describes how a single run reports. | ||
| """ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.