Skip DDB Enhanced Client extension processing for unusued extensions#6743
Open
Skip DDB Enhanced Client extension processing for unusued extensions#6743
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
The extension system creates context objects and invokes all configured extensions on every operation. By default, the Enhanced Client includes VersionedRecordExtension and AtomicCounterExtension, which run even when beans don't use either extension.
ChainExtension invokes each extension's beforeWrite() and afterRead() methods, creating a context object for each invocation. With 2 default extensions, this overhead accounts for ~2-15% CPU time, including extension invocation, context creation, and result merging.
This PR adds
shouldProcess()method to theDynamoDbEnhancedClientExtensioninterface with a default implementation returning true for backwards compatibility.Extensions can override this method to check if they're configured for a specific table schema.
Flamegrahps
Get SMALL
Before
After
Put SMALL
Before
two calls ~8% + ~3% around ~11%
After
