Initial support for Kerberos auth - #7211
Open
dagnir wants to merge 1 commit into
Open
Conversation
This commit adds - A new enum `ProxyAuthScheme` that enumerates the proxy auth mechanisms supported by Netty - `ProxyAuthGenerator` (internal) that knows how to generate the auth params for its respective auth scheme - `NegotiateProxyAuthGenerator` for Kerberos
joviegas
approved these changes
Aug 3, 2026
| */ | ||
| @SdkInternalApi | ||
| public class NegotiateProxyAuthGenerator implements ProxyAuthGenerator { | ||
| private static final String OID = "1.3.6.1.5.5.2"; |
Contributor
There was a problem hiding this comment.
nit : was wondering if need to mention a little bit more detail on the OID ,something like
// SPNEGO pseudo-mechanism OID. Lets the proxy negotiate Kerberos over HTTP "Negotiate".
private static final String SPNEGO_MECHANISM_OID = "1.3.6.1.5.5.2";| * Supported auth schemes for authentication with a proxy. | ||
| */ | ||
| @SdkPublicApi | ||
| public enum ProxyAuthScheme { |
Contributor
There was a problem hiding this comment.
nit : just for my understanding .
Is there any cases this can be used by other Http clients like crt-http , if yes then should we consider moving this interfaces to a common package shared by the sdk http clients ?
Contributor
Author
There was a problem hiding this comment.
I thought about moving this to SPI package but it doesn't seem like a good fit since we don't have a common proxy config interface.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Initial part for implementation #7033.
Modifications
This commit adds
ProxyAuthSchemethat enumerates the proxy auth mechanisms supported by NettyProxyAuthGenerator(internal) that knows how to generate the auth params for its respective auth schemeNegotiateProxyAuthGeneratorfor KerberosTesting
Screenshots (if appropriate)
Types of changes
Checklist
mvn installsucceedsscripts/new-changescript and following the instructions. Commit the new file created by the script in.changes/next-releasewith your changes.License