Repository navigation
Fix TransferManager resume corrupting ranged downloads - #7411
Merged
S-Saranya1 merged 14 commits intoOct 7, 2026
Merged
S-Saranya1 merged 14 commits into
S-Saranya1 merged 14 commits into
Conversation
Updated category to 'S3 Transfer Manager' for clarity.
alextwoods
previously approved these changes
Oct 1, 2026
alextwoods
reviewed
Oct 2, 2026
alextwoods
approved these changes
Oct 5, 2026
zoewangg
approved these changes
Oct 5, 2026
S-Saranya1
enabled auto-merge
October 5, 2026 22:04
github-merge-queue
Bot
removed this pull request from the merge queue due to no response for status checks
Oct 7, 2026
|
This pull request has been closed and the conversation has been locked. Comments on closed PRs are hard for our team to see. If you need more assistance, please open a new issue that references this one. |
S-Saranya1
deleted the
somepal/transfer-manager-resume-range-incorrectly-computed-fix
branch
October 7, 2026 18:08
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
S3TransferManager.resumeDownloadFile computes the wrong Range header when resuming a ranged download. The resume path in ResumableRequestConverter#resumedDownloadFileRequest uses bytes=bytesTransferred-contentLength (whole object size), ignoring the original range offset. This produces a silently corrupt file, wrong bytes, wrong size, no error.
Modifications
ResumableRequestConverter: extracted range computation into computeResumedRange and parseRange. When the original request had a range, the resumed range is now bytes=(originalStart+bytesTransferred)-originalEnd. Non-ranged downloads fall through to the existing behavior.
Testing
Screenshots (if appropriate)
Types of changes
Checklist
mvn installsucceedsscripts/new-changescript and following the instructions. Commit the new file created by the script in.changes/next-releasewith your changes.License