Skip to content

Fix status code mapping for RPCv2 - #7425

Merged
dagnir merged 4 commits into
masterfrom
dongie/fault-mapping-update
Oct 7, 2026
Merged

dagnir merged 4 commits into
masterfrom
dongie/fault-mapping-update

Conversation

@dagnir

@dagnir dagnir commented Oct 5, 2026 •

Copy link
Copy Markdown
Contributor

Fix for RPCv2 error unmarshalling to default to 500 HTTP status code for server side faults, and 400 for non-faults when an explicit HTTP status code is not provided in the model. This default mapping only has an effect when the response being unmarshalled does not have the status code set.

Also makes the code more robust so that new protocols raise a codegen error if the code in ProtocolSpec is not updated.

Motivation and Context

Modifications

Testing

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed
  • I have added a changelog entry. Adding a new entry must be accomplished by running the scripts/new-change script and following the instructions. Commit the new file created by the script in .changes/next-release with your changes.
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • I confirm that this pull request can be released under the Apache 2 license

@dagnir
dagnir requested a review from a team as a code owner October 5, 2026 21:04
Comment thread .changes/next-release/bugfix-AWSSDKforJavav2-88fd478.json Outdated
Fix for RPCv2 error unmarshalling to default to 500 HTTP status code for
server side faults, and 400 for non-faults when an explicit HTTP status
code is not provided in the model. This default mapping only has an
effect when the response being unmarshalled does not have the status
code set.

Also makes the code more rebost so that new protocols raise a codegen
error if the code in ProtocolSpec is not updated.
@dagnir
dagnir force-pushed the dongie/fault-mapping-update branch from 565e032 to 20866a9 Compare October 5, 2026 21:28
@dagnir
dagnir enabled auto-merge October 5, 2026 21:36
@dagnir

dagnir commented Oct 6, 2026

Copy link
Copy Markdown
Contributor Author

Successful build blocked on #7426.

@dagnir
dagnir added this pull request to the merge queue Oct 7, 2026
Merged via the queue into master with commit 4f81b70 Oct 7, 2026
13 of 14 checks passed
@github-actions

github-actions Bot commented Oct 7, 2026

Copy link
Copy Markdown

This pull request has been closed and the conversation has been locked. Comments on closed PRs are hard for our team to see. If you need more assistance, please open a new issue that references this one.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Oct 7, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants