Repository navigation
Fix status code mapping for RPCv2 - #7425
Merged
Merged
Conversation
alextwoods
reviewed
Oct 5, 2026
Fix for RPCv2 error unmarshalling to default to 500 HTTP status code for server side faults, and 400 for non-faults when an explicit HTTP status code is not provided in the model. This default mapping only has an effect when the response being unmarshalled does not have the status code set. Also makes the code more rebost so that new protocols raise a codegen error if the code in ProtocolSpec is not updated.
dagnir
force-pushed
the
dongie/fault-mapping-update
branch
from
October 5, 2026 21:28
565e032 to
20866a9
Compare
alextwoods
approved these changes
Oct 5, 2026
dagnir
enabled auto-merge
October 5, 2026 21:36
Contributor
Author
|
Successful build blocked on #7426. |
|
This pull request has been closed and the conversation has been locked. Comments on closed PRs are hard for our team to see. If you need more assistance, please open a new issue that references this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for RPCv2 error unmarshalling to default to 500 HTTP status code for server side faults, and 400 for non-faults when an explicit HTTP status code is not provided in the model. This default mapping only has an effect when the response being unmarshalled does not have the status code set.
Also makes the code more robust so that new protocols raise a codegen error if the code in ProtocolSpec is not updated.
Motivation and Context
Modifications
Testing
Screenshots (if appropriate)
Types of changes
Checklist
mvn installsucceedsscripts/new-changescript and following the instructions. Commit the new file created by the script in.changes/next-releasewith your changes.License