fix: prevent fatal on long user passwords#191
Closed
Yehonal wants to merge 1 commit into
Closed
Conversation
Member
Author
|
Closing as duplicate. Keeping #192 as the active PR for this fix; it has the same patch and CI is passing there. |
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes a PHP fatal error in the WordPress plugin’s password validation path when a password exceeds the AzerothCore max length by ensuring the length constant reference is properly qualified.
Changes:
- Use
UserValidator::PASSWORD_LENGTH(instead of an undefinedPASSWORD_LENGTH) in the “password too long” validation error path. - Improve the “password too long” validation message wording to be clearer (“%s characters or fewer”).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+24
to
+25
| __("Password is too long (%s), please use %s characters or fewer", 'acore_wp_plugin'), | ||
| strlen($password), UserValidator::PASSWORD_LENGTH |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
UserValidator::PASSWORD_LENGTHand make the validation message explicit.Why
WordPress-generated passwords can exceed the 16-character ACore account limit. The validator attempted to return a readable error, but referenced an undefined global
PASSWORD_LENGTHconstant, causing a PHP fatal error instead.Testing
git show --check HEADphp -l/ runtime PHP validation because PHP is not installed on this worker.