test(client): add integration test for RPC hook accumulation #563
+95
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
🟡 Heimdall Review Status
|
Add integration test to verify that multiple RPC-providing extensions are all accessible when installed together. This test ensures that the BaseBuilder properly accumulates RPC hooks instead of replacing them. The test verifies: - TxPool RPC (base_transactionStatus) is reachable - Metering RPC (base_meterBlockByNumber) is reachable Both should work simultaneously when both extensions are installed. Closes base#458
Himess
force-pushed
the
test/rpc-hook-accumulation-458
branch
from
6a34396 to
236a7ce
Compare
Use vec![] macro instead of Vec::new() + push pattern to satisfy clippy::vec_init_then_push lint.
Contributor
|
This didn't compile for me without a small fix. Can you verify this? |
The jsonrpsee crate doesn't have a 'types' feature. Instead, use the separate jsonrpsee-types crate which provides the ErrorCode type.
Contributor
Author
|
Thanks for catching that. Fixed the crate doesn't have a feature, we need to use the separate crate instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add integration test verifying multiple RPC extensions work together.
Tests that both
TxPoolExtensionandMeteringExtensionRPCs areaccessible when installed simultaneously.
Closes #458