fix(docs): warn that client-side SIWE nonce provides no replay protection#1722
Open
Kewe63 wants to merge 1 commit into
Open
fix(docs): warn that client-side SIWE nonce provides no replay protection#1722Kewe63 wants to merge 1 commit into
Kewe63 wants to merge 1 commit into
Conversation
…tion The 'Replace auth and identity' code example in the Base App migration guide generates the nonce in the browser with generateSiweNonce(). A client-issued nonce provides no replay protection — any attacker who captures a valid SIWE message + signature pair can replay it against the server, because the server has no record of which nonces it issued. Add a prominent <Warning> block immediately before the code example explaining the security limitation and pointing developers at the Authenticate users guide for the server-issued nonce pattern. The existing <Note> disclaimer closer to the example is kept for context but the new <Warning> is harder to miss. Fixes base#1452
Collaborator
🟡 Heimdall Review Status
|
|
👍🔥
A.P.P
El El mar, jul 14, 2026 a la(s) 06:12, Heimdall ***@***.***>
escribió:
… *cb-heimdall* left a comment (base/docs#1722)
<#1722 (comment)>
🟡 Heimdall Review Status
Requirement Status More Info
Reviews 🟡 0/2 Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
2 if repo is sensitive 0
From .codeflow.yml 1
Additional review requirements Show calculation
*Max* *0* 0
From CODEOWNERS 0
Global minimum 0
*Max* * 1 * 1
1 if commit is unverified 1
*Sum* *2*
—
Reply to this email directly, view it on GitHub
<#1722?email_source=notifications&email_token=CGGJC6SUTUHEFJAMW5JEWTL5EYWUJA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTIOJWHE2TGMRQGY2KM4TFMFZW63VKON2WE43DOJUWEZLEUVSXMZLOOSWGM33PORSXEX3DNRUWG2Y#issuecomment-4969532064>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/CGGJC6XMWBNQGQSQNLJAT2D5EYWUJAVCNFSNUABFKJSXA33TNF2G64TZHM4TONJQGM2TCMJZHNEXG43VMU5TIOBYGMZTOMZVGM2KC5QC>
.
Triage notifications, keep track of coding agent tasks and review pull
requests on the go with GitHub Mobile for iOS
<https://github.com/notifications/mobile/ios/CGGJC6TB337AC7ZCH5ZXMSL5EYWUJA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTIOJWHE2TGMRQGY2KM4TFMFZW63VKON2WE43DOJUWEZLEUVSXMZLOOSVGM33PORSXEX3JN5ZQ>
and Android
<https://github.com/notifications/mobile/android/CGGJC6ULMCIYO3EHANO3IOL5EYWUJA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTIOJWHE2TGMRQGY2KM4TFMFZW63VKON2WE43DOJUWEZLEUVSXMZLOOSXGM33PORSXEX3BNZSHE33JMQ>.
Download it today!
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1452
Adds a prominent
<Warning>block above the SIWE code example in the "Replace auth and identity" step of the Base App migration guide. The example generates the SIWE nonce withgenerateSiweNonce()in the browser; a client-issued nonce provides no replay protection — any attacker who captures a valid message + signature pair can replay it against the server because the server has no record of which nonces it issued.The new warning explicitly:
The existing
<Note>disclaimer that sits closer to the code example is kept for context but is easier to miss — the new<Warning>immediately above the example is harder to overlook.Changes
docs/apps/guides/migrate-to-standard-web-app.mdx(Step "Replace auth and identity", before the SIWE code example)<Warning>block calling out the replay protection gap.How to Test
docs/apps/guides/migrate-to-standard-web-app.mdxand navigate to the "Replace auth and identity" step.<Warning>directly above the SIWE code snippet./base-account/guides/authenticate-users.Checklist
Risk & Impact
None. Documentation-only addition of a warning block. No code, config, or behavior changes.
Type: 🐛 Bug fix / 📝 Documentation update
Fixes: #1452