docs(spec): add missing "staking" tag to shared plugin vocabulary#89
Open
memosr wants to merge 1 commit into
Open
docs(spec): add missing "staking" tag to shared plugin vocabulary#89memosr wants to merge 1 commit into
memosr wants to merge 1 commit into
Conversation
The Existing Plugin Conformance table (line 381) lists Aerodrome with the tag "staking", but "staking" is absent from the shared vocabulary list under "Choosing each field's value" (line 60). The spec itself states that new tags should be added to the vocabulary list so it remains shared across plugins. Adding "staking" closes the self-contained inconsistency: the spec now matches what its own conformance table requires. Inserted in alphabetical/logical position after "liquidity", matching the slot used in Aerodrome's tag row.
Collaborator
🟡 Heimdall Review Status
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Aerodrome ships
stakingin its tags row, but the shared vocabulary doesn't include it.Why this matters
The spec itself states:
Right now the conformance table requires a tag that the vocabulary doesn't list — anyone authoring a new plugin and following the spec literally would think
stakingisn't an approved tag, while Aerodrome ships it. Either:staking, ORstakingaddedSince
stakingis a legitimate category Aerodrome covers and the file's own conformance table treats it as valid, the vocabulary is the side to fix.The fix
Single-line addition.
stakinginserted afterliquidityin the vocabulary list, matching the slot used in Aerodrome's tag row.Verification
skills/base-mcp/references/plugin-spec.mdRelated issues
None.