Skip to content

Fix search timeout, sort vocabulary, and metadata handling #557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jeremy merged 1 commit into from
Jul 25, 2026
Merged

Fix search timeout, sort vocabulary, and metadata handling #557

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .surface
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11352,6 +11352,9 @@ FLAG basecamp search --agent type=bool
FLAG basecamp search --all type=bool
FLAG basecamp search --cache-dir type=string
FLAG basecamp search --count type=bool
FLAG basecamp search --creator type=string
FLAG basecamp search --exclude-chat type=bool
FLAG basecamp search --file-type type=string
FLAG basecamp search --help type=bool
FLAG basecamp search --hints type=bool
FLAG basecamp search --ids-only type=bool
Expand All @@ -11366,10 +11369,12 @@ FLAG basecamp search --no-stats type=bool
FLAG basecamp search --profile type=string
FLAG basecamp search --project type=string
FLAG basecamp search --quiet type=bool
FLAG basecamp search --since type=string
FLAG basecamp search --sort type=string
FLAG basecamp search --stats type=bool
FLAG basecamp search --styled type=bool
FLAG basecamp search --todolist type=string
FLAG basecamp search --type type=string
FLAG basecamp search --verbose type=count
FLAG basecamp search metadata --account type=string
FLAG basecamp search metadata --agent type=bool
Expand Down
2 changes: 1 addition & 1 deletion API-COVERAGE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ The **Since** column tags each row with the Basecamp version that introduced its
| people | 12 | `people`, `me` | ✅ | BC4 | - | list, show, pingable, add, remove (BC5: `tagline` alias of `bio` on person output) |
| **Search & Recordings** |
| my_assignments | 3 | `assignments` | ✅ | BC4 | - | list (priorities/non-priorities), completed, due (with scope filter) |
| search | 2 | `search` | ✅ | BC4 | - | Full-text search |
| search | 2 | `search` | ✅ | BC4 | - | Full-text search + metadata. Filters: `--project`/`--in`, `--type`, `--creator`, `--since` (BC5-only), `--file-type`, `--exclude-chat`. Metadata lists recording/file search types |
| recordings | 4 | `recordings` | ✅ | BC4 | - | Browse by type/status, trash/archive/restore |
| **Files & Documents** |
| uploads | 8 | `files`, `uploads` | ✅ | BC4 | - | list, show |
Expand Down
8 changes: 3 additions & 5 deletions e2e/smoke/smoke_misc_read.bats
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,10 +28,8 @@ setup_file() {

@test "search metadata returns metadata" {
run_smoke basecamp search metadata --json
# Search metadata requires projects with search enabled
if [[ "$status" -ne 0 ]]; then
mark_unverifiable "Search metadata not available"
return 0
fi
# Empty metadata is deliberate success now (SDK schema drift, not an error);
# only genuine transport/API failures should fail here.
assert_success
assert_json_value '.ok' 'true'
}
2 changes: 1 addition & 1 deletion go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ require (
charm.land/bubbles/v2 v2.1.1
charm.land/bubbletea/v2 v2.0.8
charm.land/lipgloss/v2 v2.0.5
github.com/basecamp/basecamp-sdk/go v0.8.1-0.20260724184307-e2c1abea4aea
github.com/basecamp/basecamp-sdk/go v0.8.1-0.20260725033239-a98f52fd3ddd
github.com/basecamp/cli v0.2.1
github.com/charmbracelet/bubbles v1.0.0
github.com/charmbracelet/glamour v1.0.0
Expand Down
4 changes: 2 additions & 2 deletions go.sum
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,8 @@ github.com/aymanbagabas/go-udiff v0.4.1 h1:OEIrQ8maEeDBXQDoGCbbTTXYJMYRCRO1fnodZ
github.com/aymanbagabas/go-udiff v0.4.1/go.mod h1:0L9PGwj20lrtmEMeyw4WKJ/TMyDtvAoK9bf2u/mNo3w=
github.com/aymerick/douceur v0.2.0 h1:Mv+mAeH1Q+n9Fr+oyamOlAkUNPWPlA8PPGR0QAaYuPk=
github.com/aymerick/douceur v0.2.0/go.mod h1:wlT5vV2O3h55X9m7iVYN0TBM0NH/MmbLnd30/FjWUq4=
github.com/basecamp/basecamp-sdk/go v0.8.1-0.20260724184307-e2c1abea4aea h1:dRwhvhnzbyXxitGbb3uGFaUIJHazztD9UgWC0XzM870=
github.com/basecamp/basecamp-sdk/go v0.8.1-0.20260724184307-e2c1abea4aea/go.mod h1:eX5mEKCdtxSfEL4P/n5AwOl21JVA/K+gRPic/Hd8W/Y=
github.com/basecamp/basecamp-sdk/go v0.8.1-0.20260725033239-a98f52fd3ddd h1:LrFwDErhoECxwyHrXg/dtmuZ82nJ5Xj4WIyE+GJs8T8=
github.com/basecamp/basecamp-sdk/go v0.8.1-0.20260725033239-a98f52fd3ddd/go.mod h1:SvHmG8I8jnB/3p8+Kqxs5NLPpvWssh8KUvr39bzRsl0=
github.com/basecamp/cli v0.2.1 h1:8GyehPVtsTXla0oOPu4QgXRjwwzJ99prlByvyi+0HRQ=
github.com/basecamp/cli v0.2.1/go.mod h1:p8tt/DatJ2LAzWO6N6tNfV8x3gF5T3IxDTo+U8FfWPo=
github.com/bmatcuk/doublestar v1.1.1/go.mod h1:UD6OnuiIn0yFxxA2le/rnRU1G4RaI4UvFv1sNto9p6w=
Expand Down
Loading
Loading