Modernize rbe_configs_gen to support Bazel 8+ by default#1071
Merged
Conversation
Member
coeuvre
commented
May 21, 2026
coeuvre
commented
- Remove obsolete '--cpp_config_targets' and '--cpp_config_repo' flags and their corresponding Option fields.
- Implement version-based automatic C++ autoconfig target and repository selection:
- Bazel < 8: uses legacy '@local_config_cc//...' target and 'local_config_cc' repo name.
- Bazel >= 8: uses canonical Bzlmod target '@@rules_cc++cc_configure_extension+local_config_cc//...' and repo name 'rules_cc++cc_configure_extension+local_config_cc'.
- Refactor target selection logic into a testable helper function and add unit tests covering the Bazel 7/8 boundary and development version fallback.
- Remove obsolete '--cpp_config_targets' and '--cpp_config_repo' flags and their corresponding Option fields. - Implement version-based automatic C++ autoconfig target and repository selection: - Bazel < 8: uses legacy '@local_config_cc//...' target and 'local_config_cc' repo name. - Bazel >= 8: uses canonical Bzlmod target '@@rules_cc++cc_configure_extension+local_config_cc//...' and repo name 'rules_cc++cc_configure_extension+local_config_cc'. - Refactor target selection logic into a testable helper function and add unit tests covering the Bazel 7/8 boundary and development version fallback.
coeuvre
requested review from
DaveGay,
rbe-toolchains-pr-bot and
smukherj1
as code owners
coeuvre
requested review from
Wyverald and
fweikert
and removed request for
DaveGay,
rbe-toolchains-pr-bot and
smukherj1
Wyverald
approved these changes
May 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.