rbeconfigsgen: Conditionally use @platforms//host based on Bazel version#1072
Merged
Conversation
Commit cb0929a changed the generated toolchain to use @platforms//host instead of @local_config_platform//:host. However, this breaks toolchain generation with Bazel 6 because @platforms//host is not supported in Bazel 6. This change dynamically selects the parent platform: - @local_config_platform//:host for Bazel < 7 - @platforms//host for Bazel >= 7 Added TestGenConfigBuild to verify the behavior.
coeuvre
requested review from
DaveGay,
rbe-toolchains-pr-bot and
smukherj1
as code owners
coeuvre
requested review from
Wyverald
and removed request for
DaveGay,
rbe-toolchains-pr-bot and
smukherj1
Wyverald
approved these changes
May 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit cb0929a changed the generated toolchain to use @platforms//host instead of @local_config_platform//:host. However, this breaks toolchain generation with Bazel 6 because @platforms//host is not supported in Bazel 6.
This change dynamically selects the parent platform:
Added TestGenConfigBuild to verify the behavior.