WS-2831: Spike Reverb to Resonance#14169
Draft
Isabella-Mitchell wants to merge 1 commit into
Draft
Conversation
victranfield
reviewed
Jul 1, 2026
| // add resonanceBeaconConfig to state? copilot says | ||
| // It is likely there to freeze the initial analytics payload so the page-view beacon is sent once per mount, not again on re-renders. | ||
| // so likely yes, e.g. | ||
| // const [resonanceBeaconConfig] = useState(resonanceParams); |
Contributor
There was a problem hiding this comment.
That looks great, would it prevent duplicate page views?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves JIRA:
Summary
A very high-level summary of easily-reproducible changes that can be understood by non-devs, and why these changes where made.
Code changes
Testing
Useful Links