Solari v8: Disable ReSTIR by default - #25513
Open
JMS55 wants to merge 1 commit into
Open
Conversation
JMS55
requested review from
SparkyPotato,
stuartparmenter and
tychedelia
and removed request for
stuartparmenter
August 22, 2026 18:42
| /// | ||
| /// This is useful for temporal techniques that need last frame's data. | ||
| #[derive(Resource, Default)] | ||
| pub struct RaytracingSceneNeedsPreviousFrameData; |
Contributor
There was a problem hiding this comment.
setup_raytracing_scene_needs_previous_frame_data can remove this every frame, might be worth updating the docs
Comment on lines
+247
to
+248
| } else { | ||
| if deferred_double_buffered { |
Contributor
There was a problem hiding this comment.
Anyone actually using these in their app would break if these get removed here wouldn't they?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Solution
AI was used to perform the vast majority of the mechanical work here, as it's mostly boring plumbing.
Showcase
ReSTIR Enabled
https://cdn.discordapp.com/attachments/1385299007445930135/1540790234495713350/image.png?ex=6a8b3c3a&is=6a89eaba&hm=a700233fd6b6b0570ba8c7555605221fd37ac3ea3959d5b1ca6a35d677298dcd&
https://cdn.discordapp.com/attachments/1385299007445930135/1540790314636410941/image.png?ex=6a8b3c4d&is=6a89eacd&hm=d0a9fac32c024c1c6a88355961851ef4e64ca3f354de8a9191daedd6c1a646e3&
ReSTIR Disabled
https://cdn.discordapp.com/attachments/1385299007445930135/1540790233594069103/image.png?ex=6a8b3c3a&is=6a89eaba&hm=9ad094f65e4e6966d65d3c723defe94434a342d3960b66b7bf3841ef26533e14&
https://cdn.discordapp.com/attachments/1385299007445930135/1540790315638587464/image.png?ex=6a8b3c4d&is=6a89eacd&hm=afd72bc11ea8417e10db34ba2ae3f2dc39147157274f8a13c14f41cb687d3e02&