Taffy node removal fix - #25535
Open
ickshonpe wants to merge 4 commits into
Open
Conversation
- `removing_node_from_ui_child_should_relayout_parent` - `removing_intermediate_ghost_should_relayout_parent` They check that a parent's layout is updated after removal of `Node` or `GhostNode` from its child.
ickshonpe
added
A-UI
ickshonpe
added
C-Testing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Taffy's
removefunction deletes a node, but if the node has a parent it leaves a stale id in its children.Add tests to
bevy_ui::layout.Solution
When removing a taffy node in
remove_entities, also remove it from its parent's children.Added two new UI tests to
bevy_ui::layout:removing_node_from_ui_child_should_relayout_parentremoving_intermediate_ghost_should_relayout_parentThey check that a parent's layout is updated after removal of
NodeorGhostNodefrom its child.