Fix sRGB luminance texture conversion - #25538
Open
issam3105 wants to merge 1 commit into
Open
Conversation
issam3105
marked this pull request as ready for review
August 24, 2026 15:38
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Fix a regression introduced by 0539e4daf.
That commit started preserving grayscale images as
R8Unorm. For sRGB textures, this loses sRGB decoding and sampling the texture as RGB returns the luminance only in the red channel.Solution
Expand
Luma8andLumaA8images to RGBA when they are loaded as sRGBShowcase
CompareVolumeandCompareTransmissionuse a grayscale JPEG as an emissive texture.TransmissionOrderTestuses a grayscale PNG as a base color texture. In both cases, grayscale areas were rendered in red instead of grayscale.Testing
CompareVolume.glb,CompareTransmission.glb, andTransmissionOrderTest.glband check that their grayscale textures are no longer red.