Fix color wheel debug performance - #25857
Merged
alice-i-cecile merged 1 commit intoSep 20, 2026
Merged
Conversation
alice-i-cecile
added
C-Performance
alice-i-cecile
approved these changes
Sep 20, 2026
Member
|
@cookie1170 @bugsweeper could I get a second quick review? :) |
alice-i-cecile
added
the
S-Needs-Review
viridia
approved these changes
Sep 20, 2026
alice-i-cecile
added
S-Ready-For-Final-Review
gregcsokas
pushed a commit
to gregcsokas/bevy
that referenced
this pull request
Sep 21, 2026
# Objective PR bevyengine#25536 fixed performance for the color sliders and plane, but not the wheel as it had not merged yet. ## Solution This PR replicates the solution by using `UiTransform` instead of `Node::left`/`Node::top` to position the thumbs. This avoids a Taffy relayout. ## Testing Ran `feathers_example`, thumbs are still positioned correctly. Performance is slightly better on my machine, around 50fps rather than 45.
mockersf
pushed a commit
that referenced
this pull request
Sep 25, 2026
# Objective PR #25536 fixed performance for the color sliders and plane, but not the wheel as it had not merged yet. ## Solution This PR replicates the solution by using `UiTransform` instead of `Node::left`/`Node::top` to position the thumbs. This avoids a Taffy relayout. ## Testing Ran `feathers_example`, thumbs are still positioned correctly. Performance is slightly better on my machine, around 50fps rather than 45.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
PR #25536 fixed performance for the color sliders and plane, but not the wheel as it had not merged yet.
Solution
This PR replicates the solution by using
UiTransforminstead ofNode::left/Node::topto position the thumbs. This avoids a Taffy relayout.Testing
Ran
feathers_gallery, thumbs are still positioned correctly. Performance is slightly better on my machine, around 50fps rather than 45.