Skip to content

Fix CI pipeline by upgrading to more recent Magento versions #352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shochdoerfer merged 2 commits into from
Jun 28, 2026
+26 −16
Merged

Fix CI pipeline by upgrading to more recent Magento versions #352

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c765e7b
Fix CI pipeline by upgrading to more recent Magento versions
shochdoerfer Jun 28, 2026
0a63435
Fix typo
shochdoerfer Jun 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 10 additions & 15 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,12 +11,12 @@ jobs:
strategy:
matrix:
operating-system: ['ubuntu-latest']
php-versions: ['8.1']
magento: ['2.4.4', '2.4.5']
php-versions: ['8.4']
magento: ['2.4.8']
coveralls: [ false ]
include:
- php-versions: '8.1'
magento: '2.4.6'
- php-versions: '8.4'
magento: '2.4.9'
operating-system: 'ubuntu-latest'
coveralls: true
steps:
Expand All @@ -34,17 +34,13 @@ jobs:
- name: Install Composer dependencies
run: composer install

- name: Install Magento 2.4.4
if: matrix.magento == '2.4.4'
run: composer update --with-dependencies magento/framework:103.0.4 laminas/laminas-code:4.5.1 symfony/yaml symfony/console madewithlove/license-checker
- name: Install Magento 2.4.8
if: matrix.magento == '2.4.8'
run: composer update --with-dependencies magento/framework:103.0.8 laminas/laminas-code:4.17.0 roave/security-advisories symfony/yaml symfony/console madewithlove/license-checker

- name: Install Magento 2.4.5
if: matrix.magento == '2.4.5'
run: composer update --with-dependencies magento/framework:103.0.5 laminas/laminas-code:4.5.2 roave/security-advisories symfony/yaml symfony/console madewithlove/license-checker

- name: Install Magento 2.4.6
if: matrix.magento == '2.4.6'
run: composer update --with-dependencies magento/framework:103.0.6 laminas/laminas-code:4.10.0 roave/security-advisories symfony/yaml symfony/console madewithlove/license-checker
- name: Install Magento 2.4.9
if: matrix.magento == '2.4.9'
run: composer update --with-dependencies magento/framework:103.0.9 laminas/laminas-code:4.17.0 roave/security-advisories symfony/yaml symfony/console madewithlove/license-checker

- name: Composer license check
run: composer check-license
Expand All @@ -58,7 +54,6 @@ jobs:
./bin/ci_markdown_neon_lint

- name: Static code analysis
if: (matrix.magento != '2.4.0' && matrix.magento != '2.4.1')
run: composer analyze

- name: Unittests
Expand Down
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ Magento: Magento 2.3.0 or higher
PHPStan: PHPStan 2.0 or higher

If you are using a Magento version that requires an older version of PHPStan (e.g. 0.12.77), you need to manually upgrade it before
installing this extension. in your composer.json Change the PHPStan version to `~2.0` and run:
installing this extension. In your composer.json Change the PHPStan version to `~2.0` and run:

```
composer update phpstan/phpstan --with-all-dependencies
Expand Down
15 changes: 15 additions & 0 deletions phpstan.neon
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,3 +70,18 @@ parameters:
-
message: '~PHPDoc tag @var assumes the expression with type~'
path: tests/bitExpert/PHPStan/Magento/Type/TestFrameworkObjectManagerDynamicReturnTypeExtensionUnitTest.php
-
message: '~Parameter #2 \$scope of method~'
path: tests/bitExpert/PHPStan/Magento/Rules/AbstractModelRetrieveCollectionViaFactoryRuleUnitTest.php
-
message: '~Parameter #2 \$scope of method~'
path: tests/bitExpert/PHPStan/Magento/Rules/AbstractModelUseServiceContractRuleUnitTest.php
-
message: '~Parameter #2 \$scope of method~'
path: tests/bitExpert/PHPStan/Magento/Rules/GetCollectionMockMethodNeedsCollectionSubclassRuleUnitTest.php
-
message: '~Parameter #2 \$scope of method~'
path: tests/bitExpert/PHPStan/Magento/Rules/ResourceModelsShouldBeUsedDirectlyRuleUnitTest.php
-
message: '~Parameter #2 \$scope of method~'
path: tests/bitExpert/PHPStan/Magento/Rules/SetTemplateDisallowedForBlockRuleUnitTest.php
Loading