BIP95: Testnet 5#2196
Merged
Merged
Conversation
murchandamus
left a comment
murchandamus
left a comment
Member
There was a problem hiding this comment.
Good first showing. I have left a few comments and suggestions.
murchandamus
left a comment
murchandamus
left a comment
Member
There was a problem hiding this comment.
Good improvements, thanks for the quick response. I gave this another read:
jonatack
reviewed
Jun 24, 2026
jonatack
left a comment
jonatack
left a comment
Member
There was a problem hiding this comment.
LGTM to me. A few minor comments.
|
|
||
| ## Reference Implementation | ||
|
|
||
| Pull request at ? |
Member
There was a problem hiding this comment.
Note that a reference implementation and test vectors (if applicable) would be needed before advancing the status from Draft to Complete.
Contributor
Author
There was a problem hiding this comment.
Noted, will follow-up here
Contributor
Author
|
Addressed smaller editing suggestions, thanks @average-gary @jonatack |
Member
|
Thanks @fjahr, draft looks RFM. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following up from the discussion on the mailing list at https://groups.google.com/g/bitcoindev/c/kGUMTxOvdJA.