Script Restoration BIPs: fix OP_RIGHT definition, clarify and adjust costing with wordspan notation, UPSHIFT, CLTV/CSV, final success-check#2204
Open
jmoik wants to merge 2 commits into
Open
Conversation
added 2 commits
June 27, 2026 16:16
- Apply BIP-0440 wordspan notation to numeric and bitvector costs. - Define OP_RIGHT as rightmost-byte extraction with bounded copying cost. - Clarify OP_UPSHIFT, CLTV/CSV, and final success-check costs.
jonatack
reviewed
Jun 28, 2026
jonatack
left a comment
Member
There was a problem hiding this comment.
I don't see any obvious errors in this change.
Are you waiting for review from anyone, or do you plan to send a mail list post to discuss?
|
|
||
| ==Changelog== | ||
|
|
||
| * 0.2.1: 2026-06-15: define wordspan notation and clarify byte-length versus word-span costs. |
Member
There was a problem hiding this comment.
It may not matter, but in both changelog additions in this pull, the date is two weeks ago.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BIP-0440: clarify wordspan costs
BIP-0441: update wordspan costs and fix OP_RIGHT
Apply BIP-0440 wordspan notation to numeric and bitvector costs.
Define OP_RIGHT as rightmost-byte extraction with bounded copying cost.
Clarify OP_UPSHIFT, CLTV/CSV, and final success-check costs.