Open
Conversation
| elif args.subcommand == 'list': | ||
| L1 = ("Date Amount Balance Memo\n" | ||
| "---------- ------- ------- ----") | ||
| print(L1) |
Owner
There was a problem hiding this comment.
There's nothing wrong with what you have here. However, it is a general principle in python that in most places where you could use a variable name you can instead use an expression. This applies particularly to function arguments. You have "L1 = " followed by "print(L1)". You could instead write "print()". That is, the above two lines would become:
print("Date Amount Balance Memo\n"
"---------- ------- ------- ----")
This is how you will typically see print statements written in Python programs.
Owner
|
Added several review comments. If you don't get to them before, addressing these would be the perfect thing for those extra hours in your first week, if you in fact have any :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This implements everything in the accounts example specification.