Added default value for named parameters, checks for parameter values, reporting for errors and fixed segmentation fault when object creation fails#60
Conversation
Added default values for named parameters so that we aren’t given uninitialized junk. Added simple parameter checking (capacity must be 1 or more, error_range must be less than 1) Added new exception type to be used when reporting errors Added check for existing filter in dealloc.
|
awesome stuff, thanks! we've been neglecting this for a while (and don't have a lot of experience with python c modules) so this is really appreciated. We should get around to validating and merging this soon-ish, but also #35, which as you can see has languished for quite a while. |
Removed extraneous forward declaration. Updated load_dabloom to have default values for named parameters. Check values for sanity (no negative capacity etc).
|
You are welcome. I will work on updating load_dabloom and check it passes On Thu, Jan 9, 2014 at 2:38 PM, Pierce Lopez notifications@github.comwrote:
|
Get up to date
* add default values for named parameters * add simple parameter checking * add new exception type to be used when reporting errors * add check for existing filter in dealloc from bitly#60
2 participants
No description provided.