fix(crypto-wallet-core): add input validation and error handling to p…#4108
Open
amussara wants to merge 1 commit intobitpay:masterfrom
Open
fix(crypto-wallet-core): add input validation and error handling to p…#4108amussara wants to merge 1 commit intobitpay:masterfrom
amussara wants to merge 1 commit intobitpay:masterfrom
Conversation
…roxy classes - Add proper input validation to ValidationProxy, DeriverProxy, and TransactionsProxy - Throw descriptive errors for unsupported chains instead of crashing on undefined - Add getSupportedChains() and isSupported() methods to all proxy classes - Add TypeScript type annotations to all proxy method parameters - Improve ETH/XRP validation with explicit URI parameter validation - Add try-catch to XRP address validation to handle malformed base58 inputs - Add comprehensive test suite for proxy error handling and edge cases - Validate address/URI inputs are non-empty strings before delegating
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…roxy classes
Description
Link to an issue if one exists and/or briefly describe what this PR does and why it's needed.
Changelog
Testing Notes
Add any helpful notes for reviewers to test your code here.
Checklist
BWCif modifying the bitcore-wallet-client package,CLIif modifying the bitcore-cli package, etc.)