Skip to content

[PM-28190] Add feature flag: pm-28190-cipher-sharing-ops-to-sdk Feature Flag#6887

Open
nikwithak wants to merge 2 commits intomainfrom
vault/pm-28190/sdk-sharing-feature-flag
Open

[PM-28190] Add feature flag: pm-28190-cipher-sharing-ops-to-sdk Feature Flag#6887
nikwithak wants to merge 2 commits intomainfrom
vault/pm-28190/sdk-sharing-feature-flag

Conversation

@nikwithak
Copy link
Copy Markdown
Contributor

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-28190

📔 Objective

Adds the feature flag pm-28190-cipher-sharing-ops-to-sdk

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jan 23, 2026

Logo
Checkmarx One – Scan Summary & Detailscfc38f97-c635-4214-b083-3b26130dbb0f

Great job! No new security vulnerabilities introduced in this pull request

@codecov
Copy link
Copy Markdown

codecov bot commented Jan 23, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 57.53%. Comparing base (e5fec6a) to head (17cb7a3).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6887      +/-   ##
==========================================
- Coverage   61.58%   57.53%   -4.06%     
==========================================
  Files        2032     2032              
  Lines       89476    89476              
  Branches     7957     7957              
==========================================
- Hits        55108    51478    -3630     
- Misses      32441    36153    +3712     
+ Partials     1927     1845      -82     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@nikwithak nikwithak force-pushed the vault/pm-28190/sdk-sharing-feature-flag branch from 4f405e1 to b3ede31 Compare February 3, 2026 21:59
@nikwithak nikwithak marked this pull request as ready for review March 16, 2026 18:19
@nikwithak nikwithak requested review from a team and gbubemismith March 16, 2026 18:20
@sonarqubecloud
Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants