Bound DNS engine caches with LRU eviction#3003
Merged
Conversation
… growth Replace unbounded dict/set caches (_wildcard_cache, _errors, _dns_warnings) with LRUCache, and increase _dns_cache from 10K to 100K entries.
Contributor
📊 Performance Benchmark Report
📈 Detailed Results (All Benchmarks)
🎯 Performance Summary✅ No significant performance changes detected (all changes <10%) 🐍 Python Version 3.11.15 |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 3.0 #3003 +/- ##
=====================================
+ Coverage 91% 91% +1%
=====================================
Files 436 436
Lines 37072 37072
=====================================
+ Hits 33677 33688 +11
+ Misses 3395 3384 -11 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
TheTechromancer
approved these changes
Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The DNS engine maintains several in-memory caches that previously used unbounded
dictandsettypes. On long-running scans these grow without limit.This replaces them with
cachetools.LRUCache:_dns_cache: 10,000 → 100,000 entries (~18 MB) -- main resolution cache, bumped up since the original was too small_wildcard_cache: unboundeddict→ LRU 10,000 entries -- wildcard detection results_dns_warnings: unboundedset→ LRU 10,000 entries -- duplicate warning suppression_errors: unboundeddict→ LRU 10,000 entries -- per-domain error countersEviction behavior is safe for all four: evicted DNS entries get re-resolved, evicted wildcard entries get re-checked, evicted warnings may print a duplicate log line, and evicted error counters reset (allowing retries, which is actually desirable in long scans where transient issues may have resolved).