-
Notifications
You must be signed in to change notification settings - Fork 6
MB-59670: GPU-Accelerated Vector Search #59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: bleve
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds a new C API function to retrieve the amount of free GPU memory in bytes. The implementation wraps the existing C++ faiss::gpu::getFreeMemory function to expose it to C callers.
- Adds
faiss_get_free_memoryfunction that takes a device ID and returns the free memory via an output parameter - Follows the established pattern for C API wrappers in the codebase
- Uses the CATCH_AND_HANDLE macro for consistent error handling
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| c_api/gpu/DeviceUtils_c.h | Declares the new faiss_get_free_memory function with proper documentation |
| c_api/gpu/DeviceUtils_c.cpp | Implements the function by wrapping faiss::gpu::getFreeMemory with appropriate error handling |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
faiss_gpu_free_memoryAPI that returns the amount of memory available in a GPU in bytes.