fix(voice): defer transcripts until chats can accept them - #246
Conversation
morgmart
left a comment
There was a problem hiding this comment.
🤖 Automated code review
Reviewed the exact three-dot comparison 7dac06f...0b51898 by static inspection only, including all six changed files, the applicable chat law, supplied GitHub checks, allowed anchors, and all supplied review threads. The supplied checks for this head are complete and successful. Final self-check covered the changed voice-transcript admission, deferral, retry, permanent-unavailability, and queued-message flows; accessibility; localization; navigation and consent/security guards; async failure, never-completes, lifecycle, and race behavior; test honesty; design-system/project rules; and duplicate overlap. One blocking multi-view lifecycle race remains; no accessibility, localization, visual-system, or unrelated-law finding was supported by the diff.
Deterministic publication result: 1 blocking and 0 non-blocking finding(s) publishable; 0 duplicate(s) suppressed.
morgmart
left a comment
There was a problem hiding this comment.
🤖 Automated code review
Fresh full static review completed for the exact three-dot comparison 7dac06f...0bceb7b. Reviewed all six changed files, applicable chat laws, supplied current-line anchors, the complete supplied thread history, and GitHub check evidence. The earlier mounted-route ownership race is fixed by route-token ownership and is covered by adversarial multi-controller, unmount, navigation, temporary-block, permanent-unavailability, stale-start, and replacement-outcome tests, so it is neither a current finding nor a duplicate suppression. Final self-check covered every changed voice flow (start, delivery, steering, queue ordering, temporary deferral, retry, permanent rejection, navigation/unmount, multi-view ownership, replacement, and startup races); accessibility; i18n/localization; navigation and consent/security-confirmation guards; async error, never-completes, lifecycle, and race behavior; test honesty; design-system and project rules; duplicate/overlap handling; and the evidence/user-effect threshold for blocking severity. No publishable finding remains. All supplied check runs for the exact head completed successfully; the combined commit status is pending with no legacy statuses, so required checks still independently govern merge readiness.
Deterministic publication result: 0 blocking and 0 non-blocking finding(s) publishable; 0 duplicate(s) suppressed.
Pending checks: 1 check(s) are not complete.
This approval reflects the completed code review only; merge readiness remains governed by the repository's required checks.
Pull Request is not mergeable
Pull Request is not mergeable
0bceb7b to
96a91d9
Compare
morgmart
left a comment
There was a problem hiding this comment.
🤖 Automated code review
Fresh full static review completed for the exact three-dot comparison 33f885e...96a91d9. Reviewed all six changed files, the applicable chat laws, supplied current-line anchors, complete supplied thread history, and GitHub check evidence. The prior mounted-route ownership race remains fixed through mount-scoped route tokens and adversarial multi-controller coverage, so it is not a current finding or duplicate suppression. Final self-check covered every changed voice flow (start, delivery, steering, queue ordering, temporary deferral and retry, permanent rejection, navigation/unmount, multi-view ownership, replacement, stale startup, and failure reconciliation); accessibility; i18n/localization; navigation and consent/security-confirmation guards; async error, never-completes, lifecycle, and race behavior; test honesty; design-system and project rules; duplicate and overlap handling; and concrete evidence plus user effect for blocking severity. No publishable finding remains. Supplied checks for the exact head are structurally valid: nine completed successfully and Tauri Rust checks (macOS) is in progress; required checks independently govern merge readiness.
Deterministic publication result: 0 blocking and 0 non-blocking finding(s) publishable; 0 duplicate(s) suppressed.
Pending checks: 1 check(s) are not complete.
This approval reflects the completed code review only; merge readiness remains governed by the repository's required checks.
Summary
Keeps accepted voice transcripts attached to their chat until they can be delivered safely.
Reviewer-reproducible examples