feat(acp): raise the default background hold cap to 30 minutes - #944
Merged
Conversation
Sessions holding for background work were truncated at the previous 10-minute cap — one Bash-tool max timeout — before longer chains of background shells and their continuations could finish. Triple the default; quiescence still ends the typical hold within seconds, and STAGED_BACKGROUND_HOLD_CAP_SECS still overrides without a rebuild. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Signed-off-by: Matt Toohey <contact@matttoohey.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sessions holding open for background work were capped at 10 minutes — one Bash-tool max timeout — which truncated longer chains of background shells and the continuations they wake before they could finish.
BackgroundHoldConfig::default().hold_capgoes from 600s to 1800s, with the doc comment explaining the new rationale (three Bash-tool ceilings of headroom, still bounded so a hung shell can't hold a session open forever).session_commands.rspolicy doc comment and its default-cap assertion.Quiescence detection is unchanged, so the typical hold still ends within seconds of the background work going quiet;
STAGED_BACKGROUND_HOLD_CAP_SECSstill overrides the cap without a rebuild, andSTAGED_BACKGROUND_HOLD=0still disables the hold entirely.