fix(cli): reject invalid moderation report statuses - #7011
Open
justadityaraj wants to merge 1 commit into
Open
Conversation
Signed-off-by: Aditya <aditya@bncw.in>
🔐 Codex Security Review
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reject unknown values for
buzz moderation reports --statusbefore a request is made.Related issue
Fixes #7009.
No duplicate pull request was open when this PR was created.
Problem
A typo such as
--status opnewas forwarded to the relay and looked like a successful empty moderation queue, which can hide open reports from moderators and agents.Fix
Use clap's existing allow-list pattern to accept only
open,resolved,dismissed, orescalated. The parser regression verifies that a supported value parses and a typo is rejected before dispatch.User impact
Invalid report-status filters now produce a CLI usage error instead of an indistinguishable empty result. Valid commands and request behavior are unchanged.
Verification
cargo fmt --all -- --check— passed.git diff --check— passed.cargo test -p buzz-cli moderation_reports_rejects_unknown_status --libandcargo check -p buzz-cli— could not link locally because this Windows host lacks MSVClink.exe; GitHub CI will run the test matrix.