fix(relay): tolerate bounded Redis fsync stalls - #7041
Open
BeelixGit wants to merge 1 commit into
Open
Conversation
🔐 Codex Security Review
|
Signed-off-by: John Budnick <BeelixGit@users.noreply.github.com>
BeelixGit
force-pushed
the
fix/redis-admission-timeout
branch
from
August 29, 2026 20:07
83b050e to
6e5f47d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
INCRafter an ambiguous response timeoutWhy
An AOF-backed Redis on a busy host can briefly exceed 500 ms during fsync. The relay currently turns that bounded durability stall into
shared rate-limit admission unavailableand can drop an otherwise valid request. Three seconds covers observed sub-1.5-second stalls while keeping a finite failure bound.Testing
cargo fmt --checkcargo test -p buzz-pubsub(26 passed, 11 Redis-gated ignored)cargo clippy -p buzz-pubsub --all-targets -- -D warnings