Skip to content

fix(relay): tolerate bounded Redis fsync stalls - #7041

Open
BeelixGit wants to merge 1 commit into
block:mainfrom
BeelixGit:fix/redis-admission-timeout
Open

fix(relay): tolerate bounded Redis fsync stalls#7041
BeelixGit wants to merge 1 commit into
block:mainfrom
BeelixGit:fix/redis-admission-timeout

Conversation

@BeelixGit

Copy link
Copy Markdown

Summary

  • raise only the pooled Redis admission operation response bound from redis-rs's 500 ms default to 3 seconds
  • preserve fail-closed rate limiting and the atomic Lua mutation
  • avoid retries, which could double-count an INCR after an ambiguous response timeout

Why

An AOF-backed Redis on a busy host can briefly exceed 500 ms during fsync. The relay currently turns that bounded durability stall into shared rate-limit admission unavailable and can drop an otherwise valid request. Three seconds covers observed sub-1.5-second stalls while keeping a finite failure bound.

Testing

  • cargo fmt --check
  • cargo test -p buzz-pubsub (26 passed, 11 Redis-gated ignored)
  • cargo clippy -p buzz-pubsub --all-targets -- -D warnings
  • deployed commit-pinned relay image on Folio
  • authenticated query succeeded while Redis was intentionally paused for 1.2 seconds; no admission-unavailable, 503, or relay error
  • post-deploy 100-request authenticated read burst passed

@BeelixGit
BeelixGit requested a review from a team as a code owner August 29, 2026 20:01
@github-actions

github-actions Bot commented Aug 29, 2026

Copy link
Copy Markdown

🔐 Codex Security Review

Status: review required for the current range.

The current range is 00e61eafa917d296104006576b7a2ddbfd58bb5a...6e5f47dbbca872032da1c3400c31a76a2e3e3bd7.
A new review must complete for this exact range. When manual authorization
is required, a Block organization member must comment exactly
@buzz-security-review 6e5f47dbbca872032da1c3400c31a76a2e3e3bd7 to authorize a new review.
Any previous review applies only to its recorded range.

Signed-off-by: John Budnick <BeelixGit@users.noreply.github.com>
@BeelixGit
BeelixGit force-pushed the fix/redis-admission-timeout branch from 83b050e to 6e5f47d Compare August 29, 2026 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant