Skip to content

fix: output submit gap only when guide enabled - #599

Merged
dreyfus92 merged 1 commit into
mainfrom
jg/text-gap
Sep 6, 2026
Merged

fix: output submit gap only when guide enabled#599
dreyfus92 merged 1 commit into
mainfrom
jg/text-gap

Conversation

@43081j

@43081j 43081j commented Sep 6, 2026

Copy link
Copy Markdown
Collaborator

In the text prompt, we output a " " prefix to align the submitted
value with the guide. When the guide is disabled, this was leaving is
with an unnecessary gap.

This fix removes that gap.

Fixes #598.

Type of change

  • Bug fix
  • Feature
  • Refactor (no behavior change)
  • Documentation
  • Performance improvement
  • Tests
  • Chore (dependencies, CI, tooling)

Checklist

  • pnpm test passes (or targeted tests for my change)
  • pnpm format has been run
  • I have added/updated tests for my changes (if applicable)
  • I have added a changeset

AI-generated code disclosure

  • This PR includes AI-generated code

@changeset-bot

changeset-bot Bot commented Sep 6, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 7f40da2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@clack/prompts Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Comment thread packages/core/test/prompts/prompt.test.ts Outdated
@pkg-pr-new

pkg-pr-new Bot commented Sep 6, 2026

Copy link
Copy Markdown

commit: 7f40da2

In the text prompt, we output a `"  "` prefix to align the submitted
value with the guide. When the guide is disabled, this was leaving is
with an unnecessary gap.

This fix removes that gap.

Fixes #598.

@dreyfus92 dreyfus92 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sweet! thanks @43081j 🫡

@dreyfus92
dreyfus92 merged commit 0547d6f into main Sep 6, 2026
9 checks passed
@dreyfus92
dreyfus92 deleted the jg/text-gap branch September 6, 2026 19:34
@bombshell-bot bombshell-bot Bot mentioned this pull request Sep 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] text: submitted value line is indented 2 spaces while active input is flush-left under withGuide: false (content shifts right on submit)

2 participants