Skip to content

Merge Ellint2 bug fix to master#1379

Merged
mborland merged 2 commits intomasterfrom
ellint_master
Mar 12, 2026
Merged

Merge Ellint2 bug fix to master#1379
mborland merged 2 commits intomasterfrom
ellint_master

Conversation

@mborland
Copy link
Member

@jzmaddock since this ellint bug was reported by @StephanTLavavej I've cherry picked your fixes to merge into master. I think it's better we ask permission to merge in the beta window rather than wait another 4ish months to ship in the following release. Once this cycles green I'll ping Marshall on the mailing list.

@codecov
Copy link

codecov bot commented Mar 12, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.34%. Comparing base (3205ae9) to head (06813c4).
⚠️ Report is 3 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1379   +/-   ##
=======================================
  Coverage   95.34%   95.34%           
=======================================
  Files         825      825           
  Lines       68160    68164    +4     
=======================================
+ Hits        64987    64991    +4     
  Misses       3173     3173           
Files with missing lines Coverage Δ
include/boost/math/special_functions/ellint_2.hpp 100.00% <100.00%> (ø)
test/test_ellint_2.hpp 100.00% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3205ae9...06813c4. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jzmaddock
Copy link
Collaborator

Good idea!

@mborland
Copy link
Member Author

Marshall approved. Merging.

@mborland mborland merged commit f468553 into master Mar 12, 2026
66 checks passed
@mborland mborland deleted the ellint_master branch March 12, 2026 17:43
@StephanTLavavej
Copy link
Contributor

Thank you so much, this will help me pick it up in MSVC so much sooner! (I wish I had gotten around to reporting this upstream to you earlier, it was sitting on my plate for some time. If only all my upstream dependencies were as awesome as you!!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants