Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1379 +/- ##
=======================================
Coverage 95.34% 95.34%
=======================================
Files 825 825
Lines 68160 68164 +4
=======================================
+ Hits 64987 64991 +4
Misses 3173 3173
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Collaborator
|
Good idea! |
Member
Author
|
Marshall approved. Merging. |
Contributor
|
Thank you so much, this will help me pick it up in MSVC so much sooner! (I wish I had gotten around to reporting this upstream to you earlier, it was sitting on my plate for some time. If only all my upstream dependencies were as awesome as you!!) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@jzmaddock since this ellint bug was reported by @StephanTLavavej I've cherry picked your fixes to merge into master. I think it's better we ask permission to merge in the beta window rather than wait another 4ish months to ship in the following release. Once this cycles green I'll ping Marshall on the mailing list.