ci: Hard require that generated code is updated in CI#2183
Merged
cgwalters merged 1 commit intobootc-dev:mainfrom May 3, 2026
Merged
ci: Hard require that generated code is updated in CI#2183cgwalters merged 1 commit intobootc-dev:mainfrom
cgwalters merged 1 commit intobootc-dev:mainfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the generation and validation of project artifacts, including man pages, JSON schemas, and TMT integration plans. It introduces a containerized workflow for binary-derived files to ensure consistency and adds a --check mode to the xtask CLI for CI integration. Review feedback suggests refactoring duplicated JSON schema processing logic into a helper function, correcting a doc comment regarding disk access in TMT generation, and adopting a recursive strategy for man page discovery to improve maintainability.
`just validate` now verifies that generated code is updated. We got burned badly by someone editing the generated code, and not noticing until the release PR which reverted the change. While I was working on this, I wanted to preserve the property that e.g. ostree and other heavier dependencies aren't required on the host system - they're only part of the container build. So using `podman build --output`, we can build generated docs etc as part of the container build, and copy them out to the host in the Justfile. Assisted-by: OpenCode (Claude Sonnet 4.6) Signed-off-by: Colin Walters <walters@verbum.org>
cgwalters
force-pushed
the
require-generation
branch
from
101fa54 to
dc69b2c
Compare
jeckersb
approved these changes
May 1, 2026
Collaborator
Author
|
A good review from gemini there for sure. |
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
just validatenow verifies that generated code is updated. We got burned badly by someone editing the generated code, and not noticing until the release PR which reverted the change.While I was working on this, I wanted to preserve the property that e.g. ostree and other heavier dependencies aren't required on the host system - they're only part of the container build.
So using
podman build --output, we can build generated docs etc as part of the container build, and copy them out to the host in the Justfile.Assisted-by: OpenCode (Claude Sonnet 4.6)