Don't swallow text from nested errors

[jeckersb]

Signed-off-by: John Eckersberg jeckersb@redhat.com

[gemini-code-assist]

Code Review

This pull request correctly addresses an issue where the detailed message of Error::Other was being swallowed by thiserror, improving debuggability. The change is correct. I've added a comment suggesting a similar improvement for GetBlobError to ensure consistent error reporting throughout the crate.

[jeckersb]

Before:

⬢ [jeckersb@toolbx bootc]$ cargo run -- container compute-composefs-digest localhost/bootc-bin
    Finished `dev` profile [optimized + debuginfo] target(s) in 0.09s
     Running `target/debug/bootc container compute-composefs-digest localhost/bootc-bin`
error: Pulling image: error

After:

⬢ [jeckersb@toolbx bootc]$ cargo run -- container compute-composefs-digest localhost/bootc-bin
    Finished `dev` profile [optimized + debuginfo] target(s) in 0.09s
     Running `target/debug/bootc container compute-composefs-digest localhost/bootc-bin`
error: Pulling image: other error: skopeo proxy unexpectedly exited during request method Initialize: exit status: 125
Error: cannot use command "podman unshare" with the remote podman client

Much more useful. I wasted a fair bit of time running that one down 😭

[jeckersb]

/gemini review

[gemini-code-assist]

Code Review

This pull request significantly improves error handling by preventing nested error messages from being swallowed. The changes to the #[error] attributes to include the underlying error details will greatly enhance debuggability. I've included a couple of suggestions to further refine the error messages for the Other variants, making them more direct and less redundant.

[gemini-code-assist]

For a general catch-all variant like Other, prefixing the error message with "other error: " can be redundant, as the variant name itself already provides this context. Displaying the wrapped error message directly often leads to cleaner and more precise error reporting.

Suggested change

	#[error("other error: {0}")]
	#[error("{0}")]

[jeckersb]

Hm I would rather explicitly know that the error came from the Other variant just so it's easier to know where it might be coming from.

[gemini-code-assist]

Similar to the Error::Other variant, prefixing the message with "other error: " is redundant for GetBlobError::Other. Displaying the contained message directly would be cleaner and more direct.

Suggested change

	#[error("other error: {0}")]
	#[error("{0}")]

[cgwalters]

Ah! This is the real fix for bootc-dev/bootc#1277 (comment)