Fetching Statistics from memcached server

[xni]

Hi!

I am very new to Go programming language, but I'd like to implement Statistics (https://cloud.google.com/appengine/docs/go/memcache/reference?csw=1#Statistics) in gomemcache library.

Could you please, take a look on my patch? I will be pleased to fix any problems in it you find.

Thank you in advance.

This is how I use it

func main() {
     ss := new(memcache.ServerList)
     ss.SetServers("127.0.0.1:11211")
     mc := memcache.NewFromSelector(ss)

     srv, _ := ss.PickServer("111")
     stats, err := mc.Stats(srv)
     if err == nil {
         fmt.Println(stats)
     }
}

[faabiosr]

Any news about this PR? When the merge will be made?

[bradfitz]

errors.New allocates each time. I'd make that a global err variable instead.

[bradfitz]

Write complete sentences.

See https://github.com/golang/go/wiki/CodeReviewComments#comment-sentences

// Hits is ...

(ending in a period)

[bradfitz]

This lacks comments.

Also, why does it take an Addr? It seems like most people would want aggregated statistics across all nodes for a method named "Stats".

Maybe this should be called "NodeStats".

[googlebot]

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

---

• If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
• If you signed the CLA as a corporation, please let us know the company's name.

[xni]

@bradfitz , thanks for your comments, it was very useful. Could you please take a look at my changes again.

[xni]

Hi! My commit has a committer email '[email protected]', and I was told that Yandex LLC has a CLA agreement (mostly contributing to the Chromium repository). Could you please check, why I did not pass the CLA check. Thanks!