MNT: move cibw's configuration to TOML#159
Draft
neutrinoceros wants to merge 2 commits intobrandon-rhodes:masterfrom
Draft
MNT: move cibw's configuration to TOML#159neutrinoceros wants to merge 2 commits intobrandon-rhodes:masterfrom
neutrinoceros wants to merge 2 commits intobrandon-rhodes:masterfrom
Conversation
neutrinoceros
commented
Mar 12, 2026
| uses: pypa/cibuildwheel@v3.3.1 | ||
| env: | ||
| # if adding python 3.15, just add cp315-* | ||
| CIBW_BUILD: "cp310-* cp311-* cp312-* cp313-* cp314-*" |
Author
There was a problem hiding this comment.
I intentionally didn't reproduce this line verbatim because cibw's already parses project.requires-python from pyproject.toml, and set the appropriate upper bound itself.
neutrinoceros
force-pushed
the
mnt/static-cibw-conf
branch
from
c37591b to
79c19d1
Compare
neutrinoceros
force-pushed
the
mnt/static-cibw-conf
branch
from
79c19d1 to
5aa8436
Compare
neutrinoceros
commented
Mar 12, 2026
| [tool.cibuildwheel] | ||
| build-verbosity = 0 | ||
| skip = [ | ||
| "*-musllinux_*", # not sure there's a good reason for this anymore ? |
Author
There was a problem hiding this comment.
very likely this was done because numpy didn't serve this target at the time, but it does now, so maybe we can re-enable it here or in a follow up PR ?
neutrinoceros
commented
Mar 12, 2026
| build-verbosity = 0 | ||
| skip = [ | ||
| "*-musllinux_*", # not sure there's a good reason for this anymore ? | ||
| "cp314t-*", |
Author
There was a problem hiding this comment.
recent versions of cibw include Free-threading 3.14 (3.14t) by default (though, not 3.13t). I assume we don't want to add it here.
FWIW it might get significantly easier to serve both builds (3.1x and 3.1xt) with a single wheel per platform in the near future, provided PEP 803 is accepted for Python 3.15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based off #155 which introduced
pyproject.tomlIncidentally also includes #153