Skip to content

Migrate from deprecated Aeron C++ API to C++ Wrapper API#4

Open
jiriskuta wants to merge 1 commit intomainfrom
aeron-cpp-wrapper-migration
Open

Migrate from deprecated Aeron C++ API to C++ Wrapper API#4
jiriskuta wants to merge 1 commit intomainfrom
aeron-cpp-wrapper-migration

Conversation

@jiriskuta
Copy link

@jiriskuta jiriskuta commented Mar 10, 2026

Replace deprecated <Aeron.h>, <FragmentAssembler.h>, <concurrent/BackOffIdleStrategy.h> includes with wrapper/ prefixed equivalents in AeronClient.hpp, and add aeron::aeron_client_wrapper as the first link library to fix the include guard collision on CountersReader.h.

Eliminates the deprecation warning about removal in Aeron 1.50.0.

Summary by CodeRabbit

  • Chores
    • Updated internal dependency management and code organization for improved modularity and maintainability.

Replace deprecated Aeron includes with wrapper/ equivalents in AeronClient.hpp
and add aeron::aeron_client_wrapper as first link library to ensure wrapper
include paths take precedence over old API headers (fixes include guard collision
on CountersReader.h). Eliminates deprecation warning about removal in 1.50.0.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@coderabbitai
Copy link

coderabbitai bot commented Mar 10, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 8c15b016-827c-4297-850d-5185a013fb1a

📥 Commits

Reviewing files that changed from the base of the PR and between 050b114 and d3b200e.

📒 Files selected for processing (2)
  • CMakeLists.txt
  • include/bringauto/async_function_execution/clients/AeronClient.hpp

Walkthrough

The changes integrate a wrapper library by adding aeron::aeron_client_wrapper as a public dependency to the shared target in CMakeLists.txt and updating three include directives in AeronClient.hpp to use wrapper-prefixed header paths.

Changes

Cohort / File(s) Summary
Wrapper Integration
CMakeLists.txt, include/bringauto/async_function_execution/clients/AeronClient.hpp
Adds aeron::aeron_client_wrapper as a public dependency and updates three include paths (Aeron.h, FragmentAssembler.h, BackOffIdleStrategy.h) to reference wrapper-prefixed versions.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change: migrating from the deprecated Aeron C++ API to the C++ Wrapper API, which is reflected in both the include path changes and the CMakeLists.txt dependency addition.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch aeron-cpp-wrapper-migration

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@jiriskuta jiriskuta self-assigned this Mar 10, 2026
@jiriskuta jiriskuta requested a review from koudis March 10, 2026 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant