Migrate from deprecated Aeron C++ API to C++ Wrapper API#4
Open
Migrate from deprecated Aeron C++ API to C++ Wrapper API#4
Conversation
Replace deprecated Aeron includes with wrapper/ equivalents in AeronClient.hpp and add aeron::aeron_client_wrapper as first link library to ensure wrapper include paths take precedence over old API headers (fixes include guard collision on CountersReader.h). Eliminates deprecation warning about removal in 1.50.0. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
WalkthroughThe changes integrate a wrapper library by adding Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace deprecated
<Aeron.h>,<FragmentAssembler.h>,<concurrent/BackOffIdleStrategy.h>includes withwrapper/prefixed equivalents inAeronClient.hpp, and addaeron::aeron_client_wrapperas the first link library to fix the include guard collision onCountersReader.h.Eliminates the deprecation warning about removal in Aeron 1.50.0.
Summary by CodeRabbit