fix(ci): pass server build secrets to nightly staging steps - #1902
Open
Nikhil (shadowfax92) wants to merge 1 commit into
Open
fix(ci): pass server build secrets to nightly staging steps#1902Nikhil (shadowfax92) wants to merge 1 commit into
Nikhil (shadowfax92) wants to merge 1 commit into
Conversation
Since the per-product nightlies started staging browseros_server locally (bun scripts/build/server.ts --ci), the REQUIRED_PROD_VARS were never provided, so shipped nightlies inlined the browseros.invalid placeholder config URL — the default browseros provider and credits endpoints could not connect. Mirror release-server.yml and pass BROWSEROS_CONFIG_URL, POSTHOG_API_KEY, SENTRY_DSN, and AGENT_RUNNER_JWT_SECRET. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01TZ3u9Dc57DL56JCsZy8uCg
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Nightlies have shipped
browseros_serverwith thehttps://browseros.invalid/...placeholder config URL since the per-product nightlies began staging the server locally withbun scripts/build/server.ts --ci(~Jul 6-8): the staging steps never passedREQUIRED_PROD_VARS(scripts/build/server/descriptor.ts), so the--ciplaceholder defaults got inlined into the binary. Result: the defaultbrowserosprovider and credits endpoints cannot connect in nightly builds (BYO-key providers unaffected). PostHog/Sentry are placeholder too.Mirrors
release-server.yml: passBROWSEROS_CONFIG_URL,POSTHOG_API_KEY,SENTRY_DSN,AGENT_RUNNER_JWT_SECRET(all existing repo secrets) to both nightly staging steps.Found while validating the chromium-151 nightly (#1900) — verified fixed by re-running the nightly on that branch with this change.
🤖 Generated with Claude Code
https://claude.ai/code/session_01TZ3u9Dc57DL56JCsZy8uCg