fix: preserve middle slides separated by --- without frontmatter (#63)#68
Merged
Merged
Conversation
…ld#63) The slide splitter toggled a single `insideFrontMatter` flag on every `---`, so a separator following a non-frontmatter slide was wrongly consumed as a closing frontmatter delimiter and the next slide's heading was parsed as YAML, silently dropping its content. Rewrite the splitter as a two-pass algorithm: first collect `---` lines outside fenced code blocks, then treat each as a slide separator unless it opens a YAML frontmatter pair (recognised only when the content between is empty or YAML-shaped, never markdown body). Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
|
To view this pull requests documentation preview, visit the following URL: Documentation is deployed and generated using docs.page. |
Collaborator
Author
|
The shape of this fix depends on the design decision still open in #67 (replacing YAML frontmatter with an Suggest waiting on #67 before merging. Full reasoning: #63 (comment) → #63 (comment) |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #63. The slide splitter toggled a single
insideFrontMatterflag on every---, so the separator after a frontmatter-less slide was wrongly consumed as a closing frontmatter delimiter — the next slide's heading was then parsed as YAML and its content silently dropped. The splitter is rewritten as a two-pass algorithm: first collect---lines outside fenced code blocks, then treat each as a separator unless it opens a YAML frontmatter pair (recognised only when the lines between are empty or YAML-shaped, never markdown body).Test plan
dart analyzeclean🤖 Generated with Claude Code