fix(ci): pin Flutter version in .fvmrc#71
Closed
leoafarias wants to merge 1 commit into
Closed
Conversation
The kuhnroyal/flutter-fvm-config-action reads .fvmrc and exports an empty FLUTTER_VERSION when only a channel is set. Subosito then installs the latest stable, and Flutter 3.41.9's pub fails to resolve engine_stamp.json with an empty version segment, breaking melos bootstrap for the superdeck Flutter package. Pin to 3.41.9 to restore reproducible CI.
|
To view this pull requests documentation preview, visit the following URL: Documentation is deployed and generated using docs.page. |
Collaborator
Author
|
Superseded — the test workflows pass with empty FLUTTER_VERSION, so pinning isn't the fix. The actual root cause is |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Pins
.fvmrcto3.41.9(current Flutter stable) so the CI workflows resolve a non-emptyFLUTTER_VERSION.Why
All four workflows (
firebase-hosting-pull-request.yml, plustest,integration-test,web-smokeintest.yml) use:After
5fc2298set.fvmrcto{ "flutter": "stable" }, the action returns an emptyFLUTTER_VERSION. Subosito installs latest stable (3.41.9 today), andmelos bootstrapthen fails onpackages/superdeck(the only Flutter SDK package) with:The double slash is an empty version segment — a Flutter 3.41.9 regression when resolving engine info from a prebuilt SDK with an unresolved version. Other (pure Dart) packages bootstrap fine.
The breakage is invisible on PRs from forks because the firebase-hosting workflow gates on
pull_request.head.repo.full_name == github.repository.Test plan
melos bootstrapcleanly across all four workflowssuperdeckpackage resolves dependencies without the engine_stamp 404